This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Handle entries with spaces #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Okay this should be all good 👍 |
| @@ -32,6 +32,7 @@ basenameScore = (string, query, score) -> | |||
| module.exports = (candidates, query, {key, maxResults}={}) -> | |||
| if query | |||
| queryHasNoSlashes = query.indexOf('/') is -1 | |||
| query = query.replace(/\ /g, '') | |||
There was a problem hiding this comment.
This is just trying to replace spaces right? I don't think you need to escape \ the space, am I missing something?
There was a problem hiding this comment.
The coffeeScript freaks out when you use an regex like / /. So I think /\ /g is the way to go.
|
I was getting a coffeescript syntax error without escaping the space. The error was something like "unexpected MATH". |
|
Fixes atom/fuzzy-finder#10 |
probablycorey
pushed a commit
that referenced
this pull request
Feb 27, 2014
Handle entries with spaces
|
Thanks @amccloud! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.