-
Notifications
You must be signed in to change notification settings - Fork 236
Conversation
c344651
to
bd5b5d0
Compare
@50Wliu Travis build fixed! |
Hmm. All languages use
I doubt we should change it. I proposed .meta.function {
.entity.name.function {
color: @color1;
}
} ... would also highlight functions/methods calls: function() {
// `functionCall` would be highlighted
// I assume `functionCall` is `entity.name.function`
functionCall();
} I suggest to add new scope under |
Can we just make |
How about .function.declaration {
.entity.name {
color: @color1;
}
}
.function-call, .method-call {
.entity.name {
color: @color2;
}
}
|
'1': | ||
'name': 'punctuation.definition.parameters.end.js' | ||
'0': | ||
'name': 'punctuation.definition.function.body.end.js' | ||
'name': 'meta.function.prototype.js' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this needs to be updated, because the entire function block shouldn't be tokenized as a prototype.
@pchaigno A few comments:
|
With this pull request, function and method bodies will be recognized under the scopes
meta.function.js
andmeta.method.js
with the headers.This is a necessary step to then recognize objects.