This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Add support for ES6 HTML-style comments #371
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also end comments when a </script> tag is encountered (bad solution, but that's the best we can do with regex right now)
|
Do you need an |
|
Of course you can review it. Though I'm pretty sure I was dissatisfied with this approach and/or something was wrong with it. Should probably have documented that somewhere because now I can't remember. |
|
Well if you still want to bring this in, just rebase the branch and I'll check the spec and make some comments on improvements. |
…l-comments # Conflicts: # grammars/javascript.cson
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also end comments when a
</script>tag is encountered. This is because HTML and JavaScript can intelligently detect when to break out of the comment and end the script block. Unfortunately, since we're using a 100% regex-based parser, there's really not much we can do to detect if we're embedded (writing this just now gave me an idea though...will look into it later). So for now we just be as conservative as possible.Unblocks atom/language-html#90