Handle files with first line shell opts. #171

ladar · 2021-12-14T22:24:36Z

Description of the Change

The shell script grammar should be applied to:

#!/bin/bash

and

#!/bin/bash -eu

But with the current release, the latter isn't being matched because the regex requires a new line after sh or bash. This regex tweak fixes that oversight.

This should match: ``` #!/bin/bash ``` and ``` #!/bin/bash -eu ``` Currently the latter isn't being matched because the regex requires a new line after `sh` or `bash`.

ladar · 2021-12-19T01:14:30Z

@icecream17 thank you for reviewing. It's always nice to see another Texan on GitHub.

@sadick254 can we get this regex tweak merged before the next release? There hasn't been any activity in this repo since April, so reaching since you appear to have commit access. Should I increment the package.json before you merge, or will you handle that?

Handle files with first line shell opts.

8ddc41d

This should match: ``` #!/bin/bash ``` and ``` #!/bin/bash -eu ``` Currently the latter isn't being matched because the regex requires a new line after `sh` or `bash`.

icecream17 approved these changes Dec 16, 2021

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Handle files with first line shell opts. #171

Handle files with first line shell opts. #171

ladar commented Dec 14, 2021 •

edited

Loading

ladar commented Dec 19, 2021

Handle files with first line shell opts. #171

Are you sure you want to change the base?

Handle files with first line shell opts. #171

Conversation

ladar commented Dec 14, 2021 • edited Loading

Description of the Change

ladar commented Dec 19, 2021

ladar commented Dec 14, 2021 •

edited

Loading