Allow regex from settings?

[jamischarles]

I'd like to override the lowercase todo's that are now cropping up all over.

The thing I really, really like about uppercase is that it is a very explicit declaration. You don't generally type TODO like that by accident.

I am getting false-positives in a lot of places.

How difficult would it be to allow building the language regex from settings? Thoughts?

[kevinsawicki]

We can revert the lower case back if it is annoying, I added it just to try it out.

[jamischarles]

That'd be my vote. Although I don't want to be overbearing :). Thanks for working on all this stuff. Still loving Atom.

[kevinsawicki]

Okay, mind doing a PR that rips it out?

[jamischarles]

Sure thing.

[jamischarles]

PR takes care of this

[caseylang]

Would it possible to optionally allow lower case? Possibly a setting flag?

[kevinsawicki]

@caseylang Yeah, that should be possible, I'll reopen this issue.

[caseylang]

Awesome! If you want, and can point me to a 'how to make plugins for dummies' guide, I'd be happy to make the change and submit a PR

[kevinsawicki]

This will definitely be interesting to think through, the way grammars work right now all patterns are loaded all the time, tying a config setting to control which patterns will be enabled will require core changes so I don't think this is something that can be fixed as a PR to this repo without those changes first happening.

My initial idea would be to add a property to the patterns that is a config setting key that controls whether the pattern is enabled or not. If there is another way we can think of doing this that doesn't require core changes I'm all for it.

[Restuta]

@keithduncan @jamischarles Can we instead of making it opt-in talk about false-positive cases? I think it's pretty hard to type something like "//todo: ". Our team used this syntax for years as well as "//todo restuta: " that explains for whom this todo belongs.

I was thinking about submitting PR that has extended regex to cover lowercase and optional \w+?before :.

[jamischarles]

Personally I prefer being able to have specific settings for your team and
people.

That being said, I've been using mainly vim recently, so this doesn't
affect me for the time being.
On Tue, Oct 13, 2015 at 10:14 PM Anton Vynogradenko <
notifications@github.com> wrote:

@keithduncan https://github.com/keithduncan @jamischarles
https://github.com/jamischarles Can we instead of making it opt-in talk
about false-positive cases? I think it's pretty hard to type something like
"//todo: ". Our team used this syntax for years as well as "//todo restuta:
" that explains for whom this todo belongs.

I was thinking about submitting PR that has extended regex to cover
lowercase and optional \w+?before :.

—
Reply to this email directly or view it on GitHub
#4 (comment).