This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Port to Windows #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm, if you're feeling up to it, a better way to do this is via Credential Vault (http://stackoverflow.com/questions/9221245/how-do-i-store-and-retrieve-credentials-from-the-windows-vault-credential-manage): the main advantage to this is that on Windows 8 and Windows 8.1, the user's passwords get synced between computers, which is pretty cool. Not a big priority of course. |
|
The Credential Vault seems great, thanks for letting me know it! |
jakobvogel
added a commit
to scireum/node-keytar
that referenced
this pull request
Oct 11, 2018
Pull from Master Repo
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Windows there is no global key store like OS X's keychain and Linux's gnome keyring, so we emulated the behavior on Windows by storing encrypted passwords in files, and made sure only user with the same logon credential as the user who encrypted the passwords can decrypt the passwords.