This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
upgrade to latest nan and address deprecations #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shiftkey
changed the title
shiftkey
force-pushed
the
upgrade-nan-usage
branch
from
d4a770e to
625350e
Compare
shiftkey
commented
Dec 28, 2018
| @@ -4,40 +4,63 @@ | |||
| namespace { | |||
|
|
|||
| NAN_METHOD(SetPassword) { | |||
| Nan::Utf8String serviceNan(info[0]); | |||
| std::string service(*serviceNan, serviceNan.length()); | |||
There was a problem hiding this comment.
nan has it's own UTF8 string abstraction that works across all the versions of v8, instead of #ifdef-ing across all the different Utf8Value versions that exist across different V8 versions, and this was the simplest way I could find to convert it into an array of bytes to then pass through to the platform-specific code.
If anyone knows a more succinct way to achieve this please let me know.
shiftkey
changed the title
shiftkey
force-pushed
the
upgrade-nan-usage
branch
from
625350e to
715b173
Compare
shiftkey
force-pushed
the
upgrade-nan-usage
branch
3 times, most recently
from
707532e to
f30203f
Compare
shiftkey
force-pushed
the
upgrade-nan-usage
branch
from
f30203f to
fb2b465
Compare
|
This has sat for a while without feedback, and given the tests all pass I plan to ship this in an update, probably |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #131
nanUtf8Valuechanges