This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Add prebuilds for Electron 11 (including Apple Silicon) #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennisameling
changed the title
shiftkey
approved these changes
Nov 19, 2020
5 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the prebuilds for Electron 11, which was released yesterday.
Looks like the issues with
node-abihave been resolved in their 2.19.3 release. I needed to switch back to the officialnode-abibecause otherwise the prebuild for Electron 11 didn't work.Since Electron now also supports Apple Silicon starting with v11, this PR also adds a separate prebuild script for that 🍎