Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Add prebuilds for Electron 12 #360

Closed
wants to merge 2 commits into from
Closed

Add prebuilds for Electron 12 #360

wants to merge 2 commits into from

Conversation

azeier
Copy link
Contributor

@azeier azeier commented Mar 4, 2021

@azeier
Copy link
Contributor Author

azeier commented Mar 4, 2021

The travis CI failure appears to be unrelated?
docker: Error response from daemon: pull access denied for node-keytar/arm64-cross-compile, repository does not exist or may require 'docker login'.

@David-Development
Copy link

Is there an ETA for this? Is there any way to build this locally until it is merged?

@azeier
Copy link
Contributor Author

azeier commented Mar 8, 2021

Updated for conflict with 1d53fd5.

@shiftkey Hey, anything else I can do to help get this merged?

@sirtimid
Copy link

+1

@shiftkey
Copy link
Contributor

@shiftkey Hey, anything else I can do to help get this merged?

@azeier I'd ignore that Travis error but sadly that's required for publishing a new release so I'm chasing up getting admin rights so I can complete #334 and finally get away from Travis and Appveyor. Hopefully in the next day or so we can be ready to publish this in a release.

@shiftkey
Copy link
Contributor

@azeier actually, this might be a legit failure:

Error: Could not detect abi for version 12.0.0 and runtime electron.  Updating "node-abi" might help solve this issue if it is a new release of electron

Is this branch rebased on master? We updated node-abi recently which is often necessary when new Electron releases are available...

@azeier
Copy link
Contributor Author

azeier commented Mar 11, 2021

I initially had the node-abi upgrade in this PR as well, before master was updated with the new node-abi version.

Though it looks like I just dropped that commit and didn't rebase. Did that now, let's see!

@azeier
Copy link
Contributor Author

azeier commented Mar 11, 2021

So it looks like the original travis issue is now resolved on the more recent linux builds.

But the osx build error is still the same even with after the rebase on master.

Edit: Attempted updating the package.json as well, but as expected, that has no impact since it's updated in the lockfile anyways. Let me know if you want me to drop that again.

The github macos build seems to be just fine.

@shiftkey
Copy link
Contributor

I tested #366 fresh on top of the latest changes and I couldn't spot anything wrong.

Thanks for the contribution anyway @azeier!

@shiftkey shiftkey closed this Mar 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants