-
Notifications
You must be signed in to change notification settings - Fork 194
Conversation
The travis CI failure appears to be unrelated? |
Is there an ETA for this? Is there any way to build this locally until it is merged? |
+1 |
@azeier I'd ignore that Travis error but sadly that's required for publishing a new release so I'm chasing up getting admin rights so I can complete #334 and finally get away from Travis and Appveyor. Hopefully in the next day or so we can be ready to publish this in a release. |
@azeier actually, this might be a legit failure:
Is this branch rebased on |
I initially had the node-abi upgrade in this PR as well, before master was updated with the new node-abi version. Though it looks like I just dropped that commit and didn't rebase. Did that now, let's see! |
So it looks like the original travis issue is now resolved on the more recent linux builds. But the osx build error is still the same even with after the rebase on master. Edit: Attempted updating the The github macos build seems to be just fine. |
Electron 12 was released on Monday:
https://github.com/electron/electron/releases/tag/v12.0.0