This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
unicode (multibyte) characters are corrupted #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome 🎉 Maybe fixes atom/atom#4268 too. This is a very important issue. Because the file would have been broken by Atom. I believe it to be resolved soon. |
|
Cool. We should pass the encoding in from atom. Can you make the encoding an option? We can fallback to utf8. |
|
Sounds cool! |
benogle
added a commit
that referenced
this pull request
Jul 9, 2015
unicode (multibyte) characters are corrupted
|
Thanks for this. It is better, but there are still a bunch of other encoding issues. I will create another issue outlining them. Encodings are hard. |
This was referenced Jul 9, 2015
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it's not safe to decode buffers to strings.
they may end part-way through a multi-byte character, hence the issue.
atom/atom#4542