Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Package README styling #622

Merged
merged 3 commits into from
Aug 11, 2015
Merged

Package README styling #622

merged 3 commits into from
Aug 11, 2015

Conversation

simurai
Copy link
Contributor

@simurai simurai commented Aug 7, 2015

This PR improves the styling of package READMEs

screen shot 2015-08-07 at 12 56 53 pm

  • <table> styling
  • <kbd> styling
  • more fixes like a, hr, blockquote, pre

Fixes #620

@simurai
Copy link
Contributor Author

simurai commented Aug 7, 2015

Empty cells in <table> don't get rendered. Maybe that shouldn't be a blocker for this PR?

@jlord
Copy link

jlord commented Aug 10, 2015

Interesting that it doesn't render empty cells. Not so terrible if empty cells are on the end, but if they're in the middle then it could throw off the table. I found the issue for this in marked.

@gjtorikian we use your roaster for our markdown. Have you run into the problem with empty table cells being skipped by marked before? I think we could patch it by handling empty cells in the table cell block level render methods in marked. What do you think? If it's not a terrible idea I can get the PR started.

@gjtorikian
Copy link

I think that makes sense.

If the PR doesn't get merged we might also be able to getting away with some kind of hack using &nbsp; to insert a space.

@jlord
Copy link

jlord commented Aug 11, 2015

@simurai Turns out that the settings-view readme doesn't have empty cells, but the raw markdown just didn't provide the any cells at all beyond the first two columns. github.com fills these in apparently.

So at first, once I discovered that, I was like, cool, there's actually no problem. But then I realized, once I gave it the empty cells, it didn't render the last cell unless it had content.

I used the marked render wrapper to insert content into blank cells, even tried the &nbsp; and that didn't help either, the last empty cell never gets included. Hmmm...

screen shot 2015-08-11 at 12 54 51 pm

@izuzak
Copy link
Contributor

izuzak commented Aug 11, 2015

@jlord I think that's this issue: atom/markdown-preview#206

@jlord
Copy link

jlord commented Aug 11, 2015

@izuzak ah, ok, thanks ✨

Then I think we should 🚢 this PR @simurai for the table styles 👍

jlord pushed a commit that referenced this pull request Aug 11, 2015
@jlord jlord merged commit c39070b into master Aug 11, 2015
@jlord jlord deleted the sm-package-readme branch August 11, 2015 11:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Markdown tables render incorrectly in package Readmes
4 participants