Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Watch parent directories on Windows #104

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

smashwilson
Copy link
Contributor

When a directory is watched on Windows, implicitly create non-recursive watchers the whole way up the directory tree to the drive root. When any directory along the way is removed or renamed, emit a synthetic { "action": "removed", "kind": "directory", "path": "/root" } event for the watch root and uninstall it.

@smashwilson
Copy link
Contributor Author

This introduces a lot of native crashes for me, which is concerning because it only touches JavaScript. I haven't been able to figure out why, though: I'm seeing different crashes when I change any of the logging or run under WinDbg, and I can't seem to replicate without this commit.

it is a mystery

I'm going to leave this unresolved for now and see how we're doing on Linux, and have another look post-:baby:.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant