-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for llama models proper messaging #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for Llama 2 models and update prompt formatting
Motivation
As Llama models continue to evolve, it's crucial to support both Llama 2 and Llama 3 models in our codebase. This PR aims to add support for Llama 2 models and update the prompt formatting logic to accommodate both model families, ensuring our application can work seamlessly with the latest advancements in language models.
Description
This PR introduces the following changes:
Added support for Llama 2 models:
meta-llama/Meta-Llama-2-7b
,meta-llama/Llama-2-7b-chat-hf
, andmeta-llama/Llama-2-70b-hf
Model
enum to include these new variantsImplemented model-specific prompt formatting:
messages_to_prompt
method to theModel
enummessages_to_llama2_prompt
function for Llama 2 modelsmessages_to_llama3_prompt
function for Llama 3 modelsRequestBody::to_generate_request
method to use the new model-specific prompt formattingUpdated the
ToolCall
struct:function_call_string
method to generate a string representation of function calls for Llama 3 promptsAdded comprehensive unit tests:
Updated documentation and comments to reflect the new changes
The prompt formatting follows the official Llama documentation:
Breaking Changes
There are no breaking changes in this PR. The existing functionality for Llama 3 models remains unchanged, and the new Llama 2 support is added in a backwards-compatible manner.
However, users should be aware that the prompt formatting for Llama 2 models differs from Llama 3 models. When switching between model families, ensure that your input adheres to the correct format for the chosen model.