Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up Elixir examples and documentation #12

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Clean up Elixir examples and documentation #12

merged 1 commit into from
Oct 11, 2023

Conversation

fadushin
Copy link
Collaborator

No description provided.

@UncleGrumpy
Copy link
Collaborator

Just one typo, but otherwise looks good.

@fadushin
Copy link
Collaborator Author

Just one typo, but otherwise looks good.

Missed it — where?

@UncleGrumpy
Copy link
Collaborator

UncleGrumpy commented Oct 11, 2023

See my comment in elixir/README.md, line 31... Sorry, I had started the review, but forgot to hit the comment button, I could see it in the "conversation", but you couldn't.

elixir/README.md Outdated

shell$ mkdir avm_deps

Download a copy of the AtomVM-libs from the AtomVM Gitbub [release repository](https://github.com/atomvm/AtomVM/releases/). Extract the contents of this archive and copy the enclosed AVM files into the `avm_deps` directory.
Download a copy of the AtomVM library (`atomvmlib-<version>.img`) from the AtomVM Github [release repository](https://github.com/atomvm/AtomVM/releases/). Copy this file into the `avm_deps` directory.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be atomvmlib-<version>.avm

@UncleGrumpy UncleGrumpy merged commit d90dd56 into master Oct 11, 2023
2 checks passed
@fadushin fadushin deleted the fixup branch October 12, 2023 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants