Add signoff check to CI #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UncleGrumpy
force-pushed
the
CI-reuse
branch
2 times, most recently
from
04cdbf3
to
a283fef
Compare
UncleGrumpy
force-pushed
the
CI-reuse
branch
2 times, most recently
from
f64efbd
to
311a870
Compare
In order to use the `Reuse Compliance` workflow all files must contain an acceptable license tag. This add the necessary tags to all of the existing examples and demos so that we can implement the reuse compliance workflow for future contributions. Signed-off-by: Winford <winford@object.stream>
Adds a copy of the reuse compliance check from AtomVM workflows, and adds coppies of licenses to `LICENSES` directory. Signed-off-by: Winford <winford@object.stream>
UncleGrumpy
commented
Mar 9, 2024
| @@ -11,6 +17,6 @@ For general information about building and executing Erlang AtomVM example progr | |||
| > **IMPORTANT** If you are running this example program on a device that supports WiFi (e.g., the ESP32 or Pico W), you must first copy the `src/config.erl-template` file to set `src/config.erl` and edit the WiFi Access Point SSID and PSK to which the ESP32 device is to connect before building this application: | |||
|
|
|||
| sta => [ | |||
| {ssid, "my_sta_ssid"}, | |||
| {psk, "my_sta_psk"} | |||
| {ssid, <<"my_sta_ssid">>}, | |||
There was a problem hiding this comment.
In case you are wondering about this change, it is compatible with both esp32 and pico. The pico wireless driver only accepts binary strings for ssid and psk.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a copy of the reuse compliance check workflow used by AtomVM, and a top level LICENSES directory, with licenses used for contributions.