Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some small bugs in install.sh #12

Merged
merged 1 commit into from
Nov 4, 2023

Conversation

UncleGrumpy
Copy link
Collaborator

@UncleGrumpy UncleGrumpy commented Nov 4, 2023

Fixes bashism in the args test in install.sh that won't work with POSIX sh, or bash in sh mode.

Modified the pre-installation check to test if the currently installed version is the same rather than just for the presence of the atomvm_packbeam directory so that upgrading to other versions will be possible with future releases.

Also adds generated doc directory to .gitignore.

@UncleGrumpy UncleGrumpy force-pushed the fix_install_freebsd branch 2 times, most recently from 242d734 to dcaf469 Compare November 4, 2023 06:18
Fixes bashism in the `args` test in `install.sh` that won't work with POSIX `sh`,
or `bash` in `sh` mode.

Modified the pre-installation check to test if the currently installed version
is the same rather than just for the presence of the `atomvm_packbeam`
directory so that upgrading to other versions will be possible with future
releases.

Signed-off-by: Winford <winford@object.stream>
.gitignore Outdated Show resolved Hide resolved
Copy link
Collaborator

@fadushin fadushin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the .gitignore issue, LGTM

@fadushin fadushin merged commit d94b4cd into atomvm:master Nov 4, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants