Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in packbeam create #16

Merged
merged 1 commit into from
Jun 3, 2024
Merged

Conversation

UncleGrumpy
Copy link
Collaborator

@UncleGrumpy UncleGrumpy commented Jun 2, 2024

Fixes bugs in packbeam create command that cause the creation to fail due to the start module always ending up undefined, and badmatch bug if the application_module is not defined, due to not utilizing the default options.

The atomvm_rebar3_plugin has been unaffected by these bugs because it utilizes packbeam_api internally.

Fixes bug in `packbeam create` command that casues the creation to fail if
the `application_module` is not defined, due to not utilizing the default
options.

Signed-off-by: Winford <winford@object.stream>
@UncleGrumpy UncleGrumpy requested review from bettio and pguyot June 2, 2024 03:47
@UncleGrumpy UncleGrumpy merged commit a3f66fd into atomvm:master Jun 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants