Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added version sub-command and fixed line number flags. #7

Merged
merged 1 commit into from
Oct 15, 2023

Conversation

fadushin
Copy link
Collaborator

This change set adds a version sub-command, so that users can determine the current version of the tool. It also fixes an issue with line number flags, whereby the old --include_lines option was being ignored. Since we are by default adding line number information to AVM files in the rebar3 plugin, we are changing the default behavior to include line number information by default. Users can remove line number information using the -r or --remove_lines flags.

Miscellaneous other fixes include:

  • Update version to 0.7.0
  • Workaround for an issue loading the atomvm_packbeam application in a release, which prevents us from getting the proper version
  • Added UPDATING.md to describe the "breaking" change in 0.7.0 (see UPDATING below)
  • Fix to Makefile to build the release target properly
  • Removed use of deprecated packbeam_api create call

UPDATING: The default behavior of not generating line number information in BEAM files has changed. By default, line number information will be generated in BEAM files. You can remove line number information using from BEAM files by using the -r (or --remove_lines) flags to the create subcommand. Note that in versions 0.6 of this tool, the --include_lines flag was ignored due to a bug in the code.

This change set adds a `version` sub-command, so that users can determine the current version of the tool.  It also fixes an issue with line number flags, whereby the old `--include_lines` option was being ignored.  Since we are by default adding line number information to AVM files in the rebar3 plugin, we are changing the default behavior to include line number information by default.  Users can remove line number information using the `-r` or `--remove_lines` flags.

Miscellaneous other fixes include:
* Update version to 0.7.0
* Workaround for an issue loading the atomvm_packbeam application in a release, which prevents us from getting the proper version
* Added UPDATING.md to describe the "breaking" change in 0.7.0 (see UPDATING below)
* Fix to Makefile to build the release target properly
* Removed use of deprecated packbeam_api create call

UPDATING: The default behavior of not generating line number information in BEAM files has changed.  By default, line number information will be generated in BEAM files.  You can remove line number information using from BEAM files by using the `-r` (or `--remove_lines`) flags to the `create` subcommand.  Note that in versions 0.6 of this tool, the `--include_lines` flag was ignored due to a bug in the code.
Signed-off-by: Fred Dushin <fred@dushin.net>
Copy link
Collaborator

@UncleGrumpy UncleGrumpy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I left a comment in UPDATING.md - was already wondering what the upgrade path might look like..
I noticed the install.sh does not offer an uninstall option (or include a separate uninstall.sh?), that might be something to consider in a future PR.

UPDATING.md Show resolved Hide resolved
@fadushin fadushin merged commit 567ddbf into master Oct 15, 2023
6 checks passed
@fadushin fadushin deleted the version-and-lines branch October 15, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants