Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Column already insert not an error anymore #753

Merged
merged 3 commits into from
Dec 5, 2022
Merged

Conversation

guimarqu
Copy link
Contributor

@guimarqu guimarqu commented Dec 5, 2022

The ColumnAlreadyInsertedColGenError was happening too frequently. It is now a warning. The user can choose to throw the warning by using the throw_column_already_inserted_warning parameter in colgen. He can also choose to hide the warning by setting show_column_already_inserted_warning to false.

close #747

@codecov
Copy link

codecov bot commented Dec 5, 2022

Codecov Report

Base: 86.90% // Head: 86.97% // Increases project coverage by +0.06% 🎉

Coverage data is based on head (6b47b37) compared to base (a1b2bcc).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #753      +/-   ##
==========================================
+ Coverage   86.90%   86.97%   +0.06%     
==========================================
  Files          59       59              
  Lines        5423     5427       +4     
==========================================
+ Hits         4713     4720       +7     
+ Misses        710      707       -3     
Impacted Files Coverage Δ
src/Algorithm/colgen.jl 87.47% <100.00%> (+0.71%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@guimarqu guimarqu merged commit 25e7c22 into master Dec 5, 2022
@guimarqu guimarqu deleted the already_insert_warn branch March 2, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ERROR: Unexpected variable state during column insertion.
1 participant