Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checker for column reduced cost calculation #818

Merged
merged 9 commits into from
Apr 18, 2023

Conversation

najaverzat
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Apr 14, 2023

Codecov Report

Patch coverage: 95.72% and project coverage change: +7.08 🎉

Comparison is base (7448c14) 50.54% compared to head (f8bc2d3) 57.62%.

❗ Current head f8bc2d3 differs from pull request most recent head 044ffa3. Consider uploading reports for the commit 044ffa3 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #818      +/-   ##
==========================================
+ Coverage   50.54%   57.62%   +7.08%     
==========================================
  Files          71       70       -1     
  Lines        5920     5600     -320     
==========================================
+ Hits         2992     3227     +235     
+ Misses       2928     2373     -555     
Impacted Files Coverage Δ
src/Algorithm/basic/cutcallback.jl 25.64% <0.00%> (ø)
src/Algorithm/colgen.jl 93.75% <ø> (+87.33%) ⬆️
src/MathProg/clone.jl 100.00% <ø> (ø)
src/MathProg/varconstr.jl 80.62% <50.00%> (+0.97%) ⬆️
src/MOIwrapper.jl 33.79% <85.71%> (+6.97%) ⬆️
src/ColGen/interface.jl 71.42% <90.00%> (+0.37%) ⬆️
src/Algorithm/colgen/printer.jl 96.38% <96.77%> (+1.30%) ⬆️
src/MathProg/projection.jl 95.19% <98.86%> (+16.93%) ⬆️
src/Algorithm/branching/interface.jl 96.15% <100.00%> (ø)
src/Algorithm/colgen/default.jl 98.71% <100.00%> (+0.25%) ⬆️
... and 1 more

... and 7 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@@ -0,0 +1 @@
222
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

file committed by mistake

@@ -63,9 +63,20 @@ ColGen.compute_sp_init_db(ctx::ColGenPrinterContext, sp::Formulation{DwSp}) = Co
ColGen.set_of_columns(ctx::ColGenPrinterContext) = ColGen.set_of_columns(ctx.inner)

function _calculate_column_reduced_cost(reform, col_ids)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rename this function _print_column_reduced_costs and create a function _calculate_column_reduced_cost(reform, col_id) that calculates the reduced of one column only?

src/Algorithm/colgen/printer.jl Outdated Show resolved Hide resolved
src/Algorithm/colgen/printer.jl Outdated Show resolved Hide resolved
najaverzat and others added 4 commits April 18, 2023 10:24
Co-authored-by: Guillaume Marques <guillaume.marques@protonmail.com>
Co-authored-by: Guillaume Marques <guillaume.marques@protonmail.com>
@guimarqu guimarqu merged commit a717511 into master Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants