Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test benders cuts #936

Merged
merged 5 commits into from
Jun 14, 2023
Merged

Test benders cuts #936

merged 5 commits into from
Jun 14, 2023

Conversation

najaverzat
Copy link
Contributor

In file benders_cuts.jl I create a formulation and I test with fixed (dumb) dual solutions that the cuts coefficients are well computed (in the case of a feasibility and an optimality cut). For the right-hand side, I test several cases ; when a variable has a upper/lower bound and also when there is an equality (but we have to check that last case, see issue #934)

@najaverzat najaverzat requested a review from guimarqu June 14, 2023 14:38
src/Algorithm/benders/default.jl Outdated Show resolved Hide resolved
test/unit/Benders/benders_cuts.jl Outdated Show resolved Hide resolved
najaverzat and others added 2 commits June 14, 2023 16:47
Co-authored-by: Guillaume Marques <guillaume.marques@protonmail.com>
Co-authored-by: Guillaume Marques <guillaume.marques@protonmail.com>
@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +8.30 🎉

Comparison is base (6c60415) 69.20% compared to head (beb79c2) 77.50%.

❗ Current head beb79c2 differs from pull request most recent head 53410f5. Consider uploading reports for the commit 53410f5 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #936      +/-   ##
==========================================
+ Coverage   69.20%   77.50%   +8.30%     
==========================================
  Files          83       79       -4     
  Lines        5877     5500     -377     
==========================================
+ Hits         4067     4263     +196     
+ Misses       1810     1237     -573     
Impacted Files Coverage Δ
src/Algorithm/benders/default.jl 88.19% <100.00%> (+35.63%) ⬆️

... and 64 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@guimarqu guimarqu merged commit 3420cd4 into master Jun 14, 2023
@guimarqu guimarqu deleted the test_benders_cuts branch June 14, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants