Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tuto custom data #962

Merged
merged 3 commits into from
Jul 4, 2023
Merged

Update tuto custom data #962

merged 3 commits into from
Jul 4, 2023

Conversation

najaverzat
Copy link
Contributor

I removed the identical subproblems from the tutorial on custom data -- but now the tuto is broken. I don't get the good solution at the end of the optimization anymore. Maybe I forgot to update something in the pricing callback ?

@najaverzat najaverzat requested a review from guimarqu June 27, 2023 11:51
@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.68 ⚠️

Comparison is base (8fe4e38) 79.85% compared to head (39d85a5) 79.18%.

❗ Current head 39d85a5 differs from pull request most recent head b1b8a8b. Consider uploading reports for the commit b1b8a8b to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #962      +/-   ##
==========================================
- Coverage   79.85%   79.18%   -0.68%     
==========================================
  Files          85       84       -1     
  Lines        6125     6086      -39     
==========================================
- Hits         4891     4819      -72     
- Misses       1234     1267      +33     

see 20 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@guimarqu
Copy link
Contributor

Maybe we should use another example for the custom data tutorial. I'm afraid the current example needs too much code.

@guimarqu guimarqu marked this pull request as ready for review July 4, 2023 11:54
@guimarqu guimarqu merged commit fd9ba7b into master Jul 4, 2023
@guimarqu guimarqu deleted the update_tuto_custom_data branch July 4, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants