Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align wiki and PR template #230

Closed
bms63 opened this issue Feb 8, 2024 · 0 comments · Fixed by #233
Closed

Align wiki and PR template #230

bms63 opened this issue Feb 8, 2024 · 0 comments · Fixed by #233

Comments

@bms63
Copy link
Collaborator

bms63 commented Feb 8, 2024

PR template should point to our wiki to check conventions and also recommend developers to make updates to wiki if we deviate from a convention or need additional guidance created
bms63 added a commit that referenced this issue Feb 11, 2024
@bms63
docs: #230 #188 PR template tweaks
d198121
bms63 added a commit that referenced this issue Feb 11, 2024
@bms63
docs: #230 #188 PR tweaks
c8c3ffc 
Merge remote-tracking branch 'origin/91-max-length' into 192_188_230_grab_bag
# Please enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.
@bms63 bms63 linked a pull request Feb 11, 2024 that will close this issue
Closes #192 #188 #230 a grab bag of issues #233
Merged
14 tasks
bms63 added a commit that referenced this issue Feb 11, 2024
@bms63
Merge pull request #233 from atorus-research/192_188_230_grab_bag
afcfcd1 
Closes #192 #188 #230 a grab bag of issues
averissimo added a commit that referenced this issue Feb 15, 2024
@averissimo
Merge remote-tracking branch 'origin/main' into 219-withr
4467be6 
* origin/main: (199 commits)
  [skip actions] Bump version to 0.3.1.9018
  corrects typo
  chore: #221 update spelling
  ci: remove admiral string that was helping identifying action on UI
  revert deliberate errors
  Trigger CI
  ci: reusing workflows from admiralci
  [skip actions] Bump version to 0.3.1.9017
  [skip actions] Bump version to 0.3.1.9016
  Update pull_request_template.md
  chore: removed duplicated documentation section in news
  chore: breaking news - turn to channel 6!
  docs: #192 remove non-user functions from reference files
  docs: #230 #188 PR template tweaks
  [skip actions] Bump version to 0.3.1.9015
  lint:reduce lenght of line
  Reduce line length less than 120 characters
  Update NEWS.md
  change argument name to length_source
  Change argument name to source_length in test-length
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Closes #192 #188 #230 a grab bag of issues atorus-research/xportr
1 participant
@bms63