Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Documentation to explain how xportr functions work #81

Closed
adchan11 opened this issue Mar 13, 2023 · 6 comments · Fixed by #191
Closed

More Documentation to explain how xportr functions work #81

adchan11 opened this issue Mar 13, 2023 · 6 comments · Fixed by #191
Assignees
Labels
documentation Improvements or additions to documentation release 0.4.0

Comments

@adchan11
Copy link
Collaborator

Hello,

As alluded to from #61 , #73 , and #69 , we realized there is some challenges in understanding how the functions work in order to troubleshoot the errors we've been getting. We spent a lot of time to read the code line by line in the functions but it would be more efficient to improve the documentation so that future users don't need to do this. I see there is a vignette:

https://github.com/atorus-research/xportr/blob/main/vignettes/xportr.Rmd

but I don't think it's enough to explain how the xportr functions work.

This is an example of the kind of documentation that would be helpful (how I explain the xportr_type function):

image
image
image
image
image

@bms63
Copy link
Collaborator

bms63 commented Mar 13, 2023

Thanks @adchan11. We are going to re-group at the end of March with a proper team and bring xportr to production-readiness.

xportr is one of those packages that is not very exciting to people - it is not tables, interactive dashboard or ADaMs, but just deals with the bottleneck of our industry xpt files! I think I have gather enough people that the workload will be doable for us to bring up the functions to the necessary level of readiness, build out better documentation and increase our unit testing capabilities.

Do you have the bandwidth to assist us?

@adchan11
Copy link
Collaborator Author

Sounds good, I can assist!

@bms63 bms63 moved this to Backlog in xportr 0.3.0 Apr 13, 2023
@elimillera elimillera moved this from Backlog to Priority in xportr 0.3.0 Apr 13, 2023
@elimillera elimillera added this to the xportr 0.3.0 milestone Apr 13, 2023
@elimillera elimillera added the documentation Improvements or additions to documentation label Apr 13, 2023
@cpiraux
Copy link
Collaborator

cpiraux commented Apr 20, 2023

In the documentation, we can see an issue with xportr_type(). I have the impression that types from ADaM_admiral_spec.xlsx: Char, Num are not handled by the function. I follow the documentation and get this message:

Image

It is not clear that Char and Num are not correct type values.
All variables are coerce to dbl:

Image

@adchan11 adchan11 mentioned this issue May 21, 2023
14 tasks
@elimillera elimillera moved this from Priority to Backlog in xportr 0.3.0 Jun 6, 2023
@elimillera elimillera removed this from the xportr 0.3.0 milestone Jun 6, 2023
@elimillera elimillera assigned vedhav and unassigned adchan11 Nov 16, 2023
@elimillera
Copy link
Member

Initial work is here: main...issue_81_documentation

@vedhav
Copy link
Collaborator

vedhav commented Nov 27, 2023

Thanks @adchan11 for the issue and PR. The deepdive.Rmd vignette that was built as part of the 0.3 version release does a good job of explaining how the xportr_* functions along with the verbose options that can be customized.
I've added a small PR making some changes to it, and that PR will close this issue. But, feel free to open a new issue if you feel that we can benefit from documenting something else.

@adchan11
Copy link
Collaborator Author

Thank you! @vedhav

bms63 added a commit that referenced this issue Dec 7, 2023
@bms63 bms63 closed this as completed in #191 Dec 7, 2023
bms63 added a commit that referenced this issue Dec 7, 2023
@github-project-automation github-project-automation bot moved this from Backlog to Done in xportr 0.3.0 Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation release 0.4.0
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants