-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase unit test coverage to over 80% #82
Comments
Hi @bms63 , I know you previously mentioned you were gathering a working group for xportr to bring it up to production level so in addition to that issue that I previously created regarding documentation of xportr functions, I can also assist in this issue! Feel free to reach out, thanks. |
@adchan11 -thanks! @elimillera Let's get the band back together and do this package proper! |
@bms63 Absolutely. pharmaverse is also doing a review of the package so we should be able to knock everything out at once. I'm back in the office on the 12th so we can start at that point. |
Please let us know what section of code you tackle for tests so others don't work on the same thing. |
Wow! Ya'll are amazing! Can we keep going to ~100%?!? We don't have a tight deadline so if we need to re-write some functions to increase testing opportunities, then lets do it! |
…verage Closes #82: Increase Test Coverage to 100%
@bms63 we recently went through autovalidate process for
admiralroche
, andxportr
was flagged as not having enough test coverage to reach our minimum threshold of 80%. I had a quick look and it looks likexportr
needs 39 more lines covered by unit tests.We have temporarily removed
xportr
from admiralroche package, but would be keen to add back in for our next release in June.Appreciate everyone is busy, however I have a Roche colleague who is keen to bridge the test coverge gap! Please let me know if this would help.
The text was updated successfully, but these errors were encountered: