Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase unit test coverage to over 80% #82

Closed
millerg23 opened this issue Mar 31, 2023 · 7 comments · Fixed by #89, #88, #87 or #102
Closed

Increase unit test coverage to over 80% #82

millerg23 opened this issue Mar 31, 2023 · 7 comments · Fixed by #89, #88, #87 or #102
Assignees
Milestone

Comments

@millerg23
Copy link

@bms63 we recently went through autovalidate process for admiralroche, and xportr was flagged as not having enough test coverage to reach our minimum threshold of 80%. I had a quick look and it looks like xportr needs 39 more lines covered by unit tests.
We have temporarily removed xportr from admiralroche package, but would be keen to add back in for our next release in June.
Appreciate everyone is busy, however I have a Roche colleague who is keen to bridge the test coverge gap! Please let me know if this would help.

@adchan11
Copy link
Collaborator

Hi @bms63 , I know you previously mentioned you were gathering a working group for xportr to bring it up to production level so in addition to that issue that I previously created regarding documentation of xportr functions, I can also assist in this issue! Feel free to reach out, thanks.

@bms63
Copy link
Collaborator

bms63 commented Mar 31, 2023

@adchan11 -thanks!

@elimillera Let's get the band back together and do this package proper!

@elimillera
Copy link
Member

@bms63 Absolutely. pharmaverse is also doing a review of the package so we should be able to knock everything out at once.

I'm back in the office on the 12th so we can start at that point.

@bms63 bms63 moved this to Backlog in xportr 0.3.0 Apr 13, 2023
@bms63 bms63 moved this from Backlog to Priority in xportr 0.3.0 Apr 13, 2023
@elimillera elimillera added this to the xportr 0.3.0 milestone Apr 13, 2023
@bms63
Copy link
Collaborator

bms63 commented Apr 18, 2023

image

@bms63
Copy link
Collaborator

bms63 commented Apr 18, 2023

Please let us know what section of code you tackle for tests so others don't work on the same thing.

@averissimo
Copy link
Collaborator

With the current PRs the code coverage will nudge just past 80% 🎉

image

@bms63
Copy link
Collaborator

bms63 commented Apr 20, 2023

Wow! Ya'll are amazing! Can we keep going to ~100%?!? We don't have a tight deadline so if we need to re-write some functions to increase testing opportunities, then lets do it!

@bms63 bms63 moved this from Priority to In Progress in xportr 0.3.0 Apr 22, 2023
@bms63 bms63 linked a pull request Apr 25, 2023 that will close this issue
@bms63 bms63 moved this from In Progress to In Review in xportr 0.3.0 May 1, 2023
@bms63 bms63 linked a pull request May 2, 2023 that will close this issue
14 tasks
bms63 added a commit that referenced this issue May 2, 2023
…verage

Closes #82: Increase Test Coverage to 100%
@github-project-automation github-project-automation bot moved this from In Review to Done in xportr 0.3.0 May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment