Update reorder messaging #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bms63
reviewed
May 5, 2023
bms63
requested changes
May 5, 2023
Co-authored-by: Ben Straub <ben.x.straub@gsk.com>
…rtr into 34-fix_ord_messaging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #34
The messaging for
xportr_orderwas just giving the number and names of variables dropped and moved to the end of the dataset.This PR updates the messaging to now report both reordered variables and variables moved to the end of the dataset.
I've also moved the test for its messaging to test-order.R out of test-messaging.