-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New functionality for conditional validation errors #105
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a broken record today, but can we get a entry in News.md
please! :)
Hello @elimillera ! Thank you for preparing this PR! Everything here looks perfect to me. My only suggestion would be that we may not need an argument for this at all. I think to warn users it totally sufficient in this case. I don't know a situation where I need xportr to error due to sometimes minor non-adherence to all ADaM standards. But if someone does, they could always set Thanks again! |
Thanks @ddsjoberg that's a really good point. I think sticking with the pattern of our other functions I would vote to keep the argument but I think changing the default to false is a better way to handle it. I think the arguments are useful if these is being used in a more automated pipeline where you want to stop execution if there are any issues like that in the output of the xpt file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple wordsmithing comments
Co-authored-by: Ben Straub <ben.x.straub@gsk.com>
Co-authored-by: Ben Straub <ben.x.straub@gsk.com>
Co-authored-by: Ben Straub <ben.x.straub@gsk.com>
Co-authored-by: Ben Straub <ben.x.straub@gsk.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Per #78, Add argument to not error out if dataset validation fails.
Fairly simple, just adding a new argument and an if else statement