Update: Closes #98 removing symbols that are no longer illegal #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sadchla-codes can you fix the failing tests? We should switch the <> to another illegal character to keep test coverage. @cpiraux can take over this issue if you need? |
cpiraux
approved these changes
May 24, 2023
tests/testthat/test-utils-xportr.R
Outdated
| expect_equal( | ||
| xpt_validate(df), | ||
| "Label 'A=foo%bar' cannot contain any non-ASCII, symbol or special characters." | ||
| "Label 'A=foo¿bar' cannot contain any non-ASCII, symbol or special characters." |
There was a problem hiding this comment.
% is an ASCII character, you could use @
There was a problem hiding this comment.
@cpiraux I don't know why @ escaped my mind... I know the PR is approved, and I used ç, would you prefer i switched it to @ instead? or you comfortable with me merging it to devel?
There was a problem hiding this comment.
ç is also fine. You can merge the branch to devel :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.