-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes 120 - Replace metacore with metadata #134
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Just a few minor comments
Is it possible to drop the |
Co-authored-by: Ben Straub <ben.x.straub@gsk.com>
Co-authored-by: Ben Straub <ben.x.straub@gsk.com>
…-with-metadata # Conflicts: # docs/404.html # docs/LICENSE-text.html # docs/LICENSE.html # docs/articles/index.html # docs/articles/xportr.html # docs/articles/xportr_files/datatables-css-0.0.0/datatables-crosstalk.css # docs/authors.html # docs/index.html # docs/news/index.html # docs/pkgdown.js # docs/pkgdown.yml # docs/reference/index.html # docs/reference/xportr-package.html # docs/reference/xportr_df_label.html # docs/reference/xportr_format.html # docs/reference/xportr_label.html # docs/reference/xportr_length.html # docs/reference/xportr_order.html # docs/reference/xportr_type.html # docs/reference/xportr_write.html
…-with-metadata # Conflicts: # R/df_label.R # R/format.R # R/label.R # R/length.R # R/order.R # R/type.R # man/xportr_df_label.Rd # man/xportr_format.Rd # man/xportr_label.Rd # man/xportr_length.Rd # man/xportr_order.Rd # man/xportr_type.Rd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you for your Pull Request!
We have developed a Pull Request template to aid you and our reviewers. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the xportr codebase remains robust and consistent.
The scope of
{xportr}
{xportr}
's scope is to enable R users to write out submission compliantxpt
files that can be delivered to a Health Authority or to downstream validation software programs. We see labels, lengths, types, ordering and formats from a dataset specification object (SDTM and ADaM) as being our primary focus. We also see messaging and warnings to users around applying information from the specification file as a primary focus. Please make sure your Pull Request meets this scope of {xportr}. If your Pull Request moves beyond this scope, please get in touch with the{xportr}
team on slack or create an issue to discuss.Please check off each task box as an acknowledgment that you completed the task. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the
devel
branch until you have checked off each task.Changes Description
metacore
withmetadata
across all the xportr functionsusethis::use_lifecycle()
Task List
devel
branch, Pull Requests tomain
should use the Release Pull Request Templatestyler
package and functions to style files accordingly.devtools::document()
so all.Rd
files in theman
folder and theNAMESPACE
file in the project root are updated appropriatelypkgdown::build_site()
and check that all affected examples are displayed correctly and that all new/updated functions occur on the "Reference" page.