Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestions on PR #141 #160

Merged
merged 3 commits into from
Jun 15, 2023
Merged

Suggestions on PR #141 #160

merged 3 commits into from
Jun 15, 2023

Conversation

averissimo
Copy link
Collaborator

@averissimo averissimo commented Jun 15, 2023 •
edited
Loading

Instead of making a bunch of loose suggestions, consider this PR against #141

  • font-weight to 500 instead of bold (middle ground between normal and bold)
  • line-height so that there's no overlap in letters
  • font-size changed to match code size
  • removes rownames from datatables on xportr vignette
  • Corrects spelling error
  • Corrects styler error

@averissimo averissimo requested a review from bms63 June 15, 2023 08:44
@averissimo averissimo mentioned this pull request Jun 15, 2023
Merged
14 tasks
bms63
bms63 approved these changes Jun 15, 2023
View reviewed changes
Copy link
Collaborator

@bms63 bms63 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!! TYTY

@bms63 bms63 merged commit f8d2800 into 84_xportr_deep_dive_vignette Jun 15, 2023
@bms63 bms63 deleted the 84_datatables branch June 15, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bms63 bms63 bms63 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@averissimo @bms63