Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hard deprecate the metacore argument #209

Merged
merged 2 commits into from
Dec 21, 2023
Merged

Conversation

vedhav
Copy link
Collaborator

@vedhav vedhav commented Dec 19, 2023

Changes Description

The use of metacore argument will now throw an error instead of a warning message.

Task List

  • The spirit of xportr is met in your Pull Request
  • Place Closes Move from Deprecate Warn to Deprecate Error #203 into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update)
  • Summary of changes filled out in the above Changes Description. Can be removed or left blank if changes are minor/self-explanatory.
  • Code is formatted according to the tidyverse style guide. Use styler package and functions to style files accordingly.
  • Updated relevant unit tests or have written new unit tests. See our Wiki for conventions used in this package.
  • Creation/updated relevant roxygen headers and examples. See our Wiki for conventions used in this package.
  • Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately
  • Run pkgdown::build_site() and check that all affected examples are displayed correctly and that all new/updated functions occur on the "Reference" page.
  • Update NEWS.md if the changes pertain to a user-facing function (i.e. it has an @export tag) or documentation aimed at users (rather than developers)
  • Make sure that the pacakge version in the NEWS.md and DESCRIPTION file is same. Don't worry about updating the version because it will be auto-updated using the vbump.yaml CI.
  • Address any updates needed for vignettes and/or templates
  • Link the issue Development Panel so that it closes after successful merging.
  • Fix merge conflicts
  • Pat yourself on the back for a job well done! Much love to your accomplishment!

@vedhav
Copy link
Collaborator Author

vedhav commented Dec 19, 2023

Before merging please make sure that the version would be auto-bumped to the one mentioned in the PR. Right now it's 0.3.1.9005

@EeethB EeethB self-requested a review December 19, 2023 18:04
@EeethB EeethB merged commit 645329c into main Dec 21, 2023
11 checks passed
@EeethB EeethB deleted the 203-stop-when-metacore-is-used branch December 21, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move from Deprecate Warn to Deprecate Error
2 participants