Closes #132 removing used SASlength from functions

NEWS.md

@@ -31,6 +31,8 @@ done to make the use of xportr functions more explicit. (#182)
 * The `label` argument from the `xportr_write()` function is deprecated in favor of the `metadata` argument. (#179)
 * The `metacore` argument, which was renamed to `metadata` in the following six xportr functions: (`xportr_df_label()`, `xportr_format()`, `xportr_label()`, `xportr_length()`, `xportr_order()`, and `xportr_type()`) in version `0.3.0` with a soft deprecation warning, has now been hard deprecated. Please update your code to use the new `metadata` argument in place of `metacore`.
 
+* `SASlength` and `SAStype` were removed since they did not have an impact on `xpt_validate` or any other functions (#132)
+
 ## Documentation
 
 * Created development version of the website (#187)

R/length.R

@@ -40,7 +40,7 @@
 #'   the column. This is passed to `haven::write` to note the variable length.
 #'
 #'
-#' @return Data frame with `SASlength` attributes for each variable.
+#' @return Data frame with SAS default length attributes for each variable.
 #'
 #' @export
 #'

R/utils-xportr.R

@@ -1,11 +1,11 @@
 #' Extract Attribute From Data
 #'
 #' @param data Dataset to be exported as xpt file
-#' @param attr SAS attributes such as label, format, type, length
+#' @param attr SAS attributes such as label, format, type
 #'
 #' @return Character vector of attributes with column names assigned
 #' @noRd
-extract_attr <- function(data, attr = c("label", "format.sas", "SAStype", "SASlength")) {
+extract_attr <- function(data, attr = c("label", "format.sas")) {
   attr <- match.arg(attr)
   out <- lapply(data, function(.x) attr(.x, attr))
   out <- vapply(out,
@@ -216,26 +216,8 @@ xpt_validate <- function(data) {
     )
   }
 
-  # 3.0 VARIABLE TYPES ----
-  types <- tolower(extract_attr(data, attr = "SAStype"))
 
-  expected_types <- c(
-    "", "text", "integer", "float", "datetime", "date", "time",
-    "partialdate", "partialtime", "partialdatetime",
-    "incompletedatetime", "durationdatetime", "intervaldatetime"
-  )
-
-  # 3.1 Invalid types --
-  chk_types <- types[which(!types %in% expected_types)]
-
-  if (length(chk_types) > 0) {
-    err_cnd <- c(
-      err_cnd,
-      glue("{fmt_vars(names(types))} must have a valid type.")
-    )
-  }
-
-  # 4.0 Format Types ----
+  # 3.0 Format Types ----
   formats <- extract_attr(data, attr = "format.sas")
 
   ## The usual expected formats in clinical trials: characters, dates

R/write.R

@@ -18,11 +18,9 @@
 #' @details
 #'   * Variable and dataset labels are stored in the "label" attribute.
 #'
-#'   * SAS length are stored in the "SASlength" attribute.
-#'
 #'   * SAS format are stored in the "SASformat" attribute.
 #'
-#'   * SAS type are stored in the "SAStype" attribute.
+#'   * SAS type are based on the `metadata` attribute.
 #'
 #' @return A data frame. `xportr_write()` returns the input data invisibly.
 #' @export

inst/WORDLIST

@@ -19,8 +19,6 @@ PHUSE
 Pharma
 Repostiory
 SASformat
-SASlength
-SAStype
 SDSP
 SDTM
 Standardisation

tests/testthat/test-length.R

@@ -2,7 +2,7 @@
 #'
 #' Tests will check for:
 #'  * Errors
-#' * Result of call will create `SASlength` attribute (`width` for each
+#' * Result of call will create SAS default length attribute (`width` for each
 #' variable)
 
 test_that("xportr_length: Accepts valid domain names in metadata object", {

tests/testthat/test-utils-xportr.R

@@ -83,16 +83,6 @@ test_that("xpt_validate: Get error message when the label contains over 40 chara
   )
 })
 
-test_that("xpt_validate: Get error message when the variable type is invalid", {
-  df <- data.frame(A = 1, B = 2)
-  attr(df$A, "SAStype") <- "integer"
-  attr(df$B, "SAStype") <- "list"
-  expect_equal(
-    xpt_validate(df),
-    "Variables `A` and `B` must have a valid type."
-  )
-})
-
 test_that("xpt_validate: Doesn't error out with iso8601 format", {
   df <- data.frame(A = 1, B = 2)
   attr(df$A, "format.sas") <- "E8601LX."