Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix order variable. Closes #8 #32

Merged
merged 4 commits into from
Jun 6, 2022
Merged

fix order variable. Closes #8 #32

merged 4 commits into from
Jun 6, 2022

Conversation

elimillera
Copy link
Member

Hey @bms63,
The logic of the xportr_order variable was really weird. Here is the fix that corrects it. I added a test but if you have any other tests or if you want to do a test run I think that would be really helpful.

Closes #8

@elimillera elimillera added the bug Something isn't working label Apr 27, 2022
@elimillera elimillera requested a review from bms63 April 27, 2022 13:33
@codecov
Copy link

codecov bot commented Apr 27, 2022

Codecov Report

Merging #32 (a85ac00) into master (495bce4) will increase coverage by 11.20%.
The diff coverage is 100.00%.

❗ Current head a85ac00 differs from pull request most recent head ed286ea. Consider uploading reports for the commit ed286ea to get more accurate results

@@             Coverage Diff             @@
##           master      #32       +/-   ##
===========================================
+ Coverage   58.00%   69.20%   +11.20%     
===========================================
  Files          10       10               
  Lines         350      354        +4     
===========================================
+ Hits          203      245       +42     
+ Misses        147      109       -38     
Impacted Files Coverage Δ
R/order.R 81.81% <100.00%> (+81.81%) ⬆️
R/utils-xportr.R 70.37% <100.00%> (+4.93%) ⬆️
R/write.R 83.33% <100.00%> (+2.08%) ⬆️
R/length.R 67.74% <0.00%> (+6.45%) ⬆️
R/messages.R 56.86% <0.00%> (+13.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53fa5a0...ed286ea. Read the comment docs.

Copy link
Collaborator

@bms63 bms63 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I renamed the test file and added a test. Spotted a weird testing issue with xportr_write. Uploaded advs.xpt just in case we want to reuse for a vignette later. Probably should of not done that but oh well

@bms63 bms63 merged commit 1617571 into master Jun 6, 2022
@bms63 bms63 deleted the order_fix branch June 6, 2022 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Order Function failing
2 participants