Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default character_types #66

Merged
merged 7 commits into from
Feb 14, 2023
Merged

Update default character_types #66

merged 7 commits into from
Feb 14, 2023

Conversation

elimillera
Copy link
Member

Per #65, dates and datetimes should be coerced to character.

@elimillera elimillera changed the base branch from main to devel November 8, 2022 21:54
@codecov
Copy link

codecov bot commented Nov 8, 2022

Codecov Report

❗ No coverage uploaded for pull request base (devel@5d06d82). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 833cca1 differs from pull request most recent head dd3caac. Consider uploading reports for the commit dd3caac to get more accurate results

@@           Coverage Diff            @@
##             devel      #66   +/-   ##
========================================
  Coverage         ?   66.00%           
========================================
  Files            ?       10           
  Lines            ?      350           
  Branches         ?        0           
========================================
  Hits             ?      231           
  Misses           ?      119           
  Partials         ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

R/zzz.R Outdated Show resolved Hide resolved
@thomas-neitmann
Copy link

@elimillera @zdz2101 I'd be great if you could merge this PR. "text" missing in the list of valid character types is a major pain point for participants of the admiral hackathon right now. I verified that after installing {xportr} from this branch columns of type "text" are no longer converted to numeric with values being set to NA.

@elimillera elimillera marked this pull request as ready for review February 14, 2023 17:38
Copy link
Collaborator

@zdz2101 zdz2101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

R/zzz.R Outdated Show resolved Hide resolved
@bms63 bms63 merged commit c7cfde3 into devel Feb 14, 2023
@bms63 bms63 deleted the feature/new-char-types branch April 23, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants