Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #69 add time formats #72

Merged
merged 2 commits into from
Feb 14, 2023
Merged

Conversation

zdz2101
Copy link
Collaborator

@zdz2101 zdz2101 commented Feb 14, 2023

Per #69 , add user's requested time formats

@zdz2101 zdz2101 linked an issue Feb 14, 2023 that may be closed by this pull request
Copy link
Collaborator

@bms63 bms63 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to take out the other time and date stuff?

@zdz2101
Copy link
Collaborator Author

zdz2101 commented Feb 14, 2023

Do we need to take out the other time and date stuff?

From my understanding when you use a metacore object or a spec it'll look something like this:

image

where type we're checking for text/char/Char/Text, etc. and the date/time/datetime stuff is under formats?

@bms63
Copy link
Collaborator

bms63 commented Feb 14, 2023

I was referring to your other comment on date and time stuff from the recent PR. I thought you spotted somethign that needed fixing??

@zdz2101
Copy link
Collaborator Author

zdz2101 commented Feb 14, 2023

I was referring to your other comment on date and time stuff from the recent PR. I thought you spotted somethign that needed fixing??

Yes, went and made an additional commit

Copy link
Collaborator

@bms63 bms63 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Legend

@zdz2101 zdz2101 merged commit b1e84c5 into devel Feb 14, 2023
@bms63 bms63 deleted the 69-xportr_write-error-in-valid-format branch April 23, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

xportr_write error in valid format
3 participants