Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logic to convert any null or NA formats to "" for haven. #74

Merged
merged 3 commits into from
Feb 23, 2023

Conversation

elimillera
Copy link
Member

This closes #69.

Idea here is to remove any null or NA formats and convert them to "". This is due to a limitation in haven that will break any NA 'sas.formats'

Copy link
Collaborator

@bms63 bms63 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks Eli! Can we put some stuff into the changelog for this and other issues. I feel like this is more of a minor release as we are really just fixing bugs and lingering issues we left from last year.

@elimillera
Copy link
Member Author

@bms63 Should be good!

Copy link
Collaborator

@bms63 bms63 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!! Thanks Eli

@bms63 bms63 merged commit 5bd830d into devel Feb 23, 2023
@bms63 bms63 deleted the rename-na-fmts branch April 23, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants