Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create pull_request_template.md #95

Closed
wants to merge 9 commits into from
Closed

Create pull_request_template.md #95

wants to merge 9 commits into from

Conversation

bms63
Copy link
Collaborator

@bms63 bms63 commented Apr 23, 2023

No description provided.

@bms63 bms63 linked an issue Apr 25, 2023 that may be closed by this pull request
@bms63 bms63 requested review from EeethB and cpiraux May 1, 2023 15:42
@bms63
Copy link
Collaborator Author

bms63 commented May 1, 2023

Hi all,

Simple PR Template with reminders on what we should be doing when working on xportr code. Let me know if anything needs to be clarified. There is a passive GitHub App that tracks the checklist (it isn't required to check them off to merge, but I like to think it is!)

I see the template helpful in two ways:

  1. Help remind us of conventions in xportr and where decisions are located
  2. Outside contributors making PRs that deviate from our conventions and asking them to complete the checklist before they request a formal review.

Happy to make updates. @averissimo already requested that we have a Summary of Changes Description to help highlight to reviewers what was done. Nice suggestion!!

.github/pull_request_template.md Show resolved Hide resolved
.github/pull_request_template.md Outdated Show resolved Hide resolved
.github/pull_request_template.md Outdated Show resolved Hide resolved
@bms63 bms63 mentioned this pull request May 2, 2023
Copy link
Collaborator

@vedhav vedhav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only thing to fix is the broken Release PR template link. Other than that LGTM.

.github/pull_request_template.md Outdated Show resolved Hide resolved
.github/pull_request_template.md Show resolved Hide resolved
@elimillera
Copy link
Member

Also @bms63 This should be merged into main so the templates take effect.

@bms63 bms63 changed the base branch from devel to main May 5, 2023 21:02
@bms63 bms63 changed the base branch from main to devel May 5, 2023 21:02
@bms63
Copy link
Collaborator Author

bms63 commented May 5, 2023

Also @bms63 This should be merged into main so the templates take effect.

That might get a little tricky as I branched from devel. Any ideas?

Also, this is just a nice to have for the next dev cycle so thinking low stress and we can wait on it ??

@bms63 bms63 closed this May 11, 2023
@bms63 bms63 deleted the 94_pr_template branch May 11, 2023 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pull Request Template
5 participants