-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create pull_request_template.md #95
Conversation
Hi all, Simple PR Template with reminders on what we should be doing when working on xportr code. Let me know if anything needs to be clarified. There is a passive GitHub App that tracks the checklist (it isn't required to check them off to merge, but I like to think it is!) I see the template helpful in two ways:
Happy to make updates. @averissimo already requested that we have a Summary of Changes Description to help highlight to reviewers what was done. Nice suggestion!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only thing to fix is the broken Release PR template link. Other than that LGTM.
Also @bms63 This should be merged into main so the templates take effect. |
That might get a little tricky as I branched from Also, this is just a nice to have for the next dev cycle so thinking low stress and we can wait on it ?? |
No description provided.