Impl more standard traits for error types (#691)

* Debug, Clone, Copy, Eq, PartialEq for all errors types
atsamd-rs · Jun 10, 2023 · 063fd8f · 063fd8f
1 parent a971cbf
commit 063fd8f
Show file tree

Hide file tree

Showing 7 changed files with 9 additions and 8 deletions.
diff --git a/hal/CHANGELOG.md b/hal/CHANGELOG.md
@@ -1,5 +1,6 @@
 # Unreleased Changes
 
+- Implement `Debug, Clone, Copy, Eq, PartialEq` for all HAL error types (#691).
 - Replace homebrew time library with `fugit` (#672)
 - Add `defmt` feature and derive `defmt::Format` for error types (#684, obsoletes #522).
 - Add `mcan` integration (#654)

diff --git a/hal/src/dmac/mod.rs b/hal/src/dmac/mod.rs
@@ -257,7 +257,7 @@ pub use channel::*;
 pub use dma_controller::*;
 pub use transfer::*;
 
-#[derive(Debug)]
+#[derive(Debug, Clone, Copy, Eq, PartialEq)]
 #[cfg_attr(feature = "defmt", derive(defmt::Format))]
 /// Runtime errors that may occur when dealing with DMA transfers.
 pub enum Error {

diff --git a/hal/src/sercom/i2c/flags.rs b/hal/src/sercom/i2c/flags.rs
@@ -73,7 +73,7 @@ impl Status {
 }
 
 /// Errors available for I2C transactions
-#[derive(Debug, Clone, Copy)]
+#[derive(Debug, Clone, Copy, Eq, PartialEq)]
 #[cfg_attr(feature = "defmt", derive(defmt::Format))]
 pub enum Error {
     BusError,

diff --git a/hal/src/sercom/spi.rs b/hal/src/sercom/spi.rs
@@ -442,7 +442,7 @@ impl TryFrom<Status> for () {
 ///
 /// The SPI peripheral only has two error types, buffer overflow and transaction
 /// length error.
-#[derive(Debug)]
+#[derive(Clone, Copy, Debug, Eq, PartialEq)]
 #[cfg_attr(feature = "defmt", derive(defmt::Format))]
 pub enum Error {
     Overflow,

diff --git a/hal/src/sercom/uart/flags.rs b/hal/src/sercom/uart/flags.rs
@@ -76,7 +76,7 @@ bitflags! {
 //=============================================================================
 
 /// Errors available for UART transactions
-#[derive(Debug, Clone, Copy)]
+#[derive(Debug, Clone, Copy, Eq, PartialEq)]
 #[cfg_attr(feature = "defmt", derive(defmt::Format))]
 pub enum Error {
     /// Detected a parity error

diff --git a/hal/src/thumbv7em/dsu.rs b/hal/src/thumbv7em/dsu.rs
@@ -14,15 +14,15 @@ pub struct Dsu {
 }
 
 /// Errors from hardware
-#[derive(Debug)]
+#[derive(Debug, Clone, Copy, Eq, PartialEq)]
 #[cfg_attr(feature = "defmt", derive(defmt::Format))]
 pub enum PeripheralError {
     /// Usually misaligned address of length
     BusError,
 }
 
 /// Error from within the DSU
-#[derive(Debug)]
+#[derive(Debug, Clone, Copy, Eq, PartialEq)]
 #[cfg_attr(feature = "defmt", derive(defmt::Format))]
 pub enum Error {
     /// Address or length was not word aligned

diff --git a/hal/src/thumbv7em/nvm.rs b/hal/src/thumbv7em/nvm.rs
@@ -78,7 +78,7 @@ pub struct Nvm {
 }
 
 /// Errors generated by the NVM peripheral
-#[derive(Debug)]
+#[derive(Debug, Clone, Copy, Eq, PartialEq)]
 #[cfg_attr(feature = "defmt", derive(defmt::Format))]
 pub enum PeripheralError {
     /// NVM error
@@ -97,7 +97,7 @@ pub enum PeripheralError {
 
 /// Driver errors
 #[non_exhaustive]
-#[derive(Debug)]
+#[derive(Debug, Clone, Copy, Eq, PartialEq)]
 #[cfg_attr(feature = "defmt", derive(defmt::Format))]
 pub enum Error {
     /// Address range outside of flash