Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add into_parts for QSpi #667

Merged
merged 1 commit into from
May 27, 2023
Merged

Conversation

tgross35
Copy link
Contributor

@tgross35 tgross35 commented Jan 23, 2023

Summary

Add into_parts for Qspi to retreive pins

Checklist

  • CHANGELOG.md for the BSP or HAL updated
  • All new or modified code is well documented, especially public items
  • No new warnings or clippy suggestions have been introduced (see CI or check locally)

If Adding a new Board

  • Board CI added to crates.json
  • Board is properly following "Tier 2" conventions, unless otherwise decided to be "Tier 1"

If Adding a new cargo feature to the HAL

  • Feature is added to the test matrix for applicable boards / PACs in crates.json

I was short on time and just needed a quick fix for my use case, but I figured I might as well open this PR to open discussion.

Is there any specific reason these methods to return the consumed pins/peripherals aren't available? Or is this a discussion that needs to happen at embedded-hal?. I've seen both into_inner and into_parts for naming, not sure which is more standard.

The quick fix I did here was for Qspi only, but the same goes for Spi, I2C, Uart, etc.

@jbeaurivage
Copy link
Contributor

@tgross35, I'm not sure every peripheral module adheres to this, but many of them call that type of function free.

@jbeaurivage
Copy link
Contributor

@tgross35 If you want to fix the formatting and rebase to master, I'll be happy to merge!

@tgross35
Copy link
Contributor Author

Thanks @jbeaurivage, I totally forgot about this.

Changed the name to free and fixed the formatting issue. I don't know whether this is changelog-worthy or not, but let me know if so and I can add an entry.

@jbeaurivage jbeaurivage merged commit eb0c887 into atsamd-rs:master May 27, 2023
@tgross35 tgross35 deleted the qspi-parts branch May 28, 2023 05:06
benvonhandorf pushed a commit to benvonhandorf/atsamd that referenced this pull request Nov 29, 2023
benvonhandorf pushed a commit to benvonhandorf/atsamd that referenced this pull request Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants