Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add
into_parts
forQspi
to retreive pinsChecklist
CHANGELOG.md
for the BSP or HAL updatedIf Adding a new Board
crates.json
If Adding a new cargo
feature
to the HALcrates.json
I was short on time and just needed a quick fix for my use case, but I figured I might as well open this PR to open discussion.
Is there any specific reason these methods to return the consumed pins/peripherals aren't available? Or is this a discussion that needs to happen at
embedded-hal
?. I've seen bothinto_inner
andinto_parts
for naming, not sure which is more standard.The quick fix I did here was for Qspi only, but the same goes for Spi, I2C, Uart, etc.