PIO: open-drain/multi-driver support #32
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tmplt this PR is a draft that doesn't even pass CI. Any chance this could be finished? |
|
I'll see about alloting some time for a fixup the coming weeks. |
|
CI passes, but I don't have hardware access at the moment for a test, at the time. |
This patch implements the open drain ("multi-driver") mode with
pull-up and pull-down for each pin.
I could not find any information indicating that the modes are not
supported for any specific pins and have as such followed the same
patterns of implementation as for the other pin modes.
Additionally, the InputPin and OutputPin traits are implemented for
OpenDrain pins. This permits using crates like onewire to quickly
implement software 1-wire support for Dallas-style sensors (ds18b20
for instance).
|
Commits cleaned up. |
|
@martinmortsell, are you able to test this? If not, objections to merging as-is to evade eventual stagnation? CC @michalfita |
|
IIRC: this didn't work as expected when we started trying it out, so you definitely want to test/fix this before merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copied from an internal Gitlab instance. By @axel-grepit: