fixup! feat(language-service): Enable go to definition of styleUrl

atscott · Sep 15, 2023 · 4d005c3 · 4d005c3
1 parent e6f240d
commit 4d005c3
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/packages/language-service/src/language_service.ts b/packages/language-service/src/language_service.ts
@@ -610,6 +610,8 @@ function isInAngularContext(program: ts.Program, fileName: string, position: num
 
   const assignment = getPropertyAssignmentFromValue(node, 'template') ??
       getPropertyAssignmentFromValue(node, 'templateUrl') ??
+      // `node.parent` is used because the string is a child of an array element and we want to get
+      // the property name
       getPropertyAssignmentFromValue(node.parent, 'styleUrls') ??
       getPropertyAssignmentFromValue(node, 'styleUrl');
   return assignment !== null && getClassDeclFromDecoratorProp(assignment) !== null;

diff --git a/packages/zone.js/lib/browser/rollup-test-main.ts b/packages/zone.js/lib/browser/rollup-test-main.ts
@@ -7,6 +7,5 @@
  */
 
 import './rollup-main';
-
 // load test related files into bundle
 import '../testing/zone-testing';
diff --git a/packages/zone.js/test/BUILD.bazel b/packages/zone.js/test/BUILD.bazel
@@ -318,7 +318,7 @@ karma_test(
     ],
     test_entry_point = ":browser_disable_wrap_uncaught_promise_rejection_entry_point.ts",
     test_srcs = [
-        "common/promise-disable-wrap-uncaught-promise-rejection.spec.ts",
         "browser_disable_wrap_uncaught_promise_rejection_entry_point.ts",
+        "common/promise-disable-wrap-uncaught-promise-rejection.spec.ts",
     ],
 )