Skip to content

Commit

Permalink
Merge pull request #1114 from atsign-foundation/rename_totp
Browse files Browse the repository at this point in the history
fix: Rename TOTP to OTP and upgraded at_commons package
  • Loading branch information
sitaram-kalluri authored Sep 4, 2023
2 parents 3f580b9 + f8488e4 commit e486a86
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion packages/at_client/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ dependencies:
async: ^2.9.0
at_utf7: ^1.0.0
at_base2e15: ^1.0.0
at_commons: ^3.0.53
at_commons: ^3.0.54
at_utils: ^3.0.15
at_chops: ^1.0.3
at_lookup: ^3.0.39
Expand Down
12 changes: 6 additions & 6 deletions tests/at_functional_test/test/enrollment_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -58,16 +58,16 @@ void main() {
expect(enrollResponseJson['enrollmentId'], isNotEmpty);
expect(enrollResponseJson['status'], 'approved');
// Fetch OTP
var totpResponse =
await atClient.getRemoteSecondary()!.executeCommand('totp:get\n');
expect(totpResponse, isNotEmpty);
String totp = totpResponse!.replaceFirst('data:', '');
var otpResponse =
await atClient.getRemoteSecondary()!.executeCommand('otp:get\n');
expect(otpResponse, isNotEmpty);
String otp = otpResponse!.replaceFirst('data:', '');

var remoteSecondary_2 = RemoteSecondary(atSign, getClient2Preferences());
var secondApkamPublicKey = at_demos.pkamPublicKeyMap[
'@bob🛠']; //choose any pkam public key part from @alice🛠
var newEnrollRequest =
'enroll:request:{"appName":"buzz","deviceName":"pixel","namespaces":{"buzz":"rw"},"totp":"$totp","apkamPublicKey":"$secondApkamPublicKey"}\n';
'enroll:request:{"appName":"buzz","deviceName":"pixel","namespaces":{"buzz":"rw"},"otp":"$otp","apkamPublicKey":"$secondApkamPublicKey"}\n';
var newEnrollResponse =
await remoteSecondary_2.executeCommand(newEnrollRequest);
print('EnrollmentResponse: $newEnrollResponse');
Expand All @@ -85,7 +85,7 @@ void main() {
expect(enrollNotification.key,
'$enrollmentIdFromServer.new.enrollments.__manage');
}, count: 1, max: -1));
}, skip: true); // TODO Needs to be un-skipped once problem has been resolved
});
}

Future<void> setLastReceivedNotificationDateTime() async {
Expand Down

0 comments on commit e486a86

Please sign in to comment.