Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add enrollmentId to SyncService/NotificationService #1151

Merged
merged 6 commits into from
Oct 26, 2023
Merged

fix: add enrollmentId to SyncService/NotificationService #1151

merged 6 commits into from
Oct 26, 2023

Conversation

murali-shris
Copy link
Member

@murali-shris murali-shris commented Oct 26, 2023 •
edited
Loading

- What I did

  • Make enrollment available to SyncService/NotificationService for authentication
    - How I did it
  • added a getter/setter for enrollmentId in at_client_spec.dart
  • set the enrollmentId in AtClientManager --> setCurrentAtSign method
  • pass the atClient.enrollmentId to Monitor constructor in NotificationServiceImpl
  • pass the atClient.enrollmentId to RemoteSecondary constructor in NotificationServiceImpl
    - How to verify it
  • point to this branch of at_client in at_onboarding_cli. functional tests should pass.
  • Run examples in at_onboarding_cli. Check examples/Readme.md
    feat: Apkam onboarding changes at_libraries#399

@murali-shris murali-shris changed the title Enrollmentid bug fix: Enrollmentid bug Oct 26, 2023
gkc
gkc requested changes Oct 26, 2023
View reviewed changes
packages/at_client/lib/src/client/at_client_impl.dart Outdated
@@ -996,4 +991,7 @@ class AtClientImpl implements AtClient, AtSignChangeListener {
}
return result.notificationID;
}

@override
String? enrollmentId;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move this up to line 117 please?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@murali-shris murali-shris changed the title fix: Enrollmentid bug fix: add enrollmentId to SyncService/NotificationService Oct 26, 2023
@murali-shris murali-shris marked this pull request as ready for review October 26, 2023 11:26
@murali-shris murali-shris requested a review from gkc October 26, 2023 11:26
gkc
gkc approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@gkc gkc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@murali-shris murali-shris merged commit 6fddd69 into trunk Oct 26, 2023
7 checks passed
@murali-shris murali-shris deleted the enrollmentid_bug branch October 26, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkc gkc gkc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@murali-shris @gkc