Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add osv-scanner to unit tests #1170

Merged
merged 2 commits into from
Nov 21, 2023
Merged

feat: Add osv-scanner to unit tests #1170

merged 2 commits into from
Nov 21, 2023

Conversation

cpswan
Copy link
Member

@cpswan cpswan commented Nov 20, 2023

OpenSSF best practices suggest using a static analysis tool to scan for known vulnerabilities.

- What I did

Added osv-scanner

- How I did it

As with atsign-foundation/at_server#1664

osv-scanner is being installed using go install (having first installed golang itself with actions/setup-go)

This is done (rather than using the OSV Scanner GitHub Action) to ensure that the pubspec.lock files are in place, which happens when we dart pub get as part of unit tests.

- How to verify it

We will have to wait for a known vulnerability to confirm that the tests fail.

- Description for the changelog

feat: Add osv-scanner to unit tests

@cpswan cpswan self-assigned this Nov 20, 2023
@gkc gkc merged commit 980ae23 into trunk Nov 21, 2023
8 checks passed
@gkc gkc deleted the cpswan-ovs-scanner branch November 21, 2023 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants