Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new method to fetch enrollment requests #1200

Closed
wants to merge 29 commits into from

Conversation

srieteja
Copy link
Contributor

@srieteja srieteja commented Jan 10, 2024

closes #1198

- What I did

- How I did it

  • fetch enroll requests: do an enroll:list on the remoteSecondary and handle the information from the server and return it as a Map<String, dynamic>

- How to verify it

  • added unit test should verify the functioning of the method

- Description for the changelog

feat: add new method to fetch enrollment requests

Copy link
Member

@sitaram-kalluri sitaram-kalluri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add functional tests to assert the changes

@sitaram-kalluri sitaram-kalluri self-requested a review January 11, 2024 12:41
packages/at_client/lib/src/client/at_client_impl.dart Outdated Show resolved Hide resolved
return _formatEnrollListResponse(enrollRequests);
}

List<EnrollmentRequest> _formatEnrollListResponse(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add fromJson and toJson to "EnrollmentRequest" class instead of setting in for loop.

EnrollmentRequest enrollmentRequest = EnrollmentRequest.fromJson(enrollRequest);

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these methods have been introduced as part of 17863da

@murali-shris murali-shris self-requested a review January 24, 2024 15:49
@srieteja
Copy link
Contributor Author

This implementation has been moved to a diff pr #1222

@srieteja srieteja closed this Jan 24, 2024
@srieteja srieteja deleted the enroll_list_client branch January 24, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fetch the pending enrollment requests from the secondary server
3 participants