-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add new method to fetch enrollment requests #1200
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add functional tests to assert the changes
return _formatEnrollListResponse(enrollRequests); | ||
} | ||
|
||
List<EnrollmentRequest> _formatEnrollListResponse( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add fromJson and toJson to "EnrollmentRequest" class instead of setting in for loop.
EnrollmentRequest enrollmentRequest = EnrollmentRequest.fromJson(enrollRequest);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these methods have been introduced as part of 17863da
This implementation has been moved to a diff pr #1222 |
closes #1198
- What I did
- How I did it
- How to verify it
- Description for the changelog
feat: add new method to fetch enrollment requests