-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: at_client put method - introduce shouldEncrypt flag #1398
Conversation
fix for functional test issue in server |
packages/at_client/lib/src/transformer/response_transformer/get_response_transformer.dart
Show resolved
Hide resolved
!(decodedResponse['key'].startsWith('cached:public:'))) { | ||
var decryptionService = AtKeyDecryptionManager(_atClient) | ||
.get(tuple.one, _atClient.getCurrentAtSign()!); | ||
// For new encrypted data after AtClient v3.2.1, isEncrypted will be true by default |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does "by default" mean? Is it more accurate to say that "isEncrypted will be set to true when data is encrypted"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isEncrypted will be set to true for self/shared keys, if caller doesn't set anything in PutRequestionOptions. I will change the wording.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes #1401
Depends on atsign-foundation/at_server#2099 for intermittent functional test failure in sync_multiple_client_test
- What I did
- How I did it
- How to verify it
Dependency tests
test: check onboarding cli for at_client publish at_libraries#673
test: noports test for at_client and onboarding cli publish noports#1387
TODO:
Replace dependency overrides with published versions
at_commons PR to be reviewed and merged
feat: at_commons changes for setting isEncrypted for both true and false at_libraries#669