Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APKAM - changes in at_onboarding_cli #367

Closed
Tracked by #29
murali-shris opened this issue Jun 26, 2023 · 12 comments
Closed
Tracked by #29

APKAM - changes in at_onboarding_cli #367

murali-shris opened this issue Jun 26, 2023 · 12 comments
Assignees
Labels
enhancement New feature or request

Comments

@murali-shris
Copy link
Member

murali-shris commented Jun 26, 2023

  • ability to onboard using apkam key pair
@murali-shris murali-shris added the enhancement New feature or request label Jun 26, 2023
@murali-shris murali-shris changed the title APKAM - ability to receive offline notifications APKAM - changes in at_onboarding_cli Jun 26, 2023
@murali-shris murali-shris changed the title APKAM - changes in at_onboarding_cli APKAM - changes in at_onboarding_cli/at_lookup Jun 26, 2023
@murali-shris murali-shris changed the title APKAM - changes in at_onboarding_cli/at_lookup APKAM - changes in at_lookup/at_chops for signing using apkam keypair Jun 26, 2023
@murali-shris murali-shris changed the title APKAM - changes in at_lookup/at_chops for signing using apkam keypair APKAM - changes in at_onboarding_cli Jun 26, 2023
@murali-shris
Copy link
Member Author

  • on completion of enroll request pkam private key should be stored in local storage
  • Read the pkam private key from local storage and use for onboarding
  • support legacy pkam auth using atKeys file as well as new apkam

@murali-shris
Copy link
Member Author

  • Started with initial changes
    b5f0c4c
  • there is a dependency on keys verb impl on server.Currently implementing keys verb.

@murali-shris
Copy link
Member Author

  • Keys verb impl done
  • Changes done in PR 66
    Onboarding for first app - impl done and tested manually
    ceb50d0
    f7f230e

@murali-shris
Copy link
Member Author

Pending changes

  • subsequent auth for first app
  • second app onboarding and auth

@murali-shris
Copy link
Member Author

No significant progress on client side changes in PR67 due to spec changes impl on server

@murali-shris
Copy link
Member Author

murali-shris commented Aug 21, 2023

Implementation and manual testing done. Automated tests pending.
Branch for onboarding_cli changes:
https://github.com/atsign-foundation/at_libraries/tree/apkam_onboarding_changes

Dependent pull requests in at_chops, at_lookup under review:
#393
#394

at_client changes in progress:
https://github.com/atsign-foundation/at_client_sdk/tree/apkam_changes

8SP burnt in PR 68, carrying over with 4SP for pending changes

@murali-shris
Copy link
Member Author

murali-shris commented Sep 5, 2023

Changes done and tested during dev_env image in local virtual environment.
Waiting for server to be released to prod and will move the PR to review.
Considerable time was spent in PR 69 for making changes to functional tests for enrollment in on_boarding_cli
#399

@murali-shris
Copy link
Member Author

Changes done in PR70

  • Onboarding can be done based on preference set in AtOnboardingPreference --> enableEnrollmentDuringOnboard.default value false (onboarding will be legacy)
    if set to true, current onboarding client will get privilege to approve enrollments.

Pending change:
Read enrollmentId from atKeys file in authenticate method if enrollmentId is not passed.

@murali-shris
Copy link
Member Author

changes done in PR 71

@murali-shris
Copy link
Member Author

changes done in PR 72

@murali-shris
Copy link
Member Author

Update in PR 73
Re-tested examples with at_client 3.0.67.
#441
Pending review and re-write examples with arg parser

@murali-shris
Copy link
Member Author

PR merged and at_onboarding_cli 1.4.0 published

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants