Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not receiving messages between atsigns using at_onboarding_cli+at_auth #19

Closed
purnimavenkatasubbu opened this issue Oct 13, 2023 · 7 comments
Assignees
Labels
bug Something isn't working

Comments

@purnimavenkatasubbu
Copy link
Member

purnimavenkatasubbu commented Oct 13, 2023

Describe the bug

Sent messages are not being displayed on the receiver's end

Steps to reproduce

  1. Clone the trunk branch of at_talk (change the dart version)

  2. Then Add the following dependency overrides
    dependency_overrides:
    at_commons: ^3.0.56
    at_lookup: ^3.0.40
    at_client:
    git:
    url: https://github.com/atsign-foundation/at_client_sdk
    ref: trunk
    path: packages/at_client
    at_onboarding_cli:
    git:
    url: https://github.com/atsign-foundation/at_libraries.git
    path: packages/at_onboarding_cli
    ref: apkam_onboarding_changes

  3. And then generate a new atsigns with register_cli(apkam_onbording_changes) branch

  4. Run the following commands for the 2 atsigns

 dart bin/at_talk.dart -k /home/shaikirfan/.atsign/keys/@yeastydotterel85_key.atKeys -a @yeastydotterel85 -t @charlie24

dart bin/at_talk.dart -k /home/shaikirfan/.atsign/keys/@charlie24_key.atKeys -a @charlie24 -t @yeastydotterel85

atTalkLOgs.txt

attalkreceiverlogs.txt
Screenshot from 2023-10-13 18-11-29

Expected behavior

Messages sent and received should be displayed.

Screenshots

Screenshot from 2023-10-13 18-11-29

attalk.mp4

Smartphones

No response

Were you using an atApplication when the bug was found?

No response

Additional context

No response

@purnimavenkatasubbu purnimavenkatasubbu added the bug Something isn't working label Oct 13, 2023
@murali-shris murali-shris changed the title Not receiving messages from each other Not receiving messages between atsigns using at_onboarding_cli+at_auth Oct 13, 2023
@purnimavenkatasubbu
Copy link
Member Author

The issue got fixed by updating AtOnboardingPreference()..useAtChops = true
atsign-1

dart bin/at_talk.dart -k /home/shaikirfan/.atsign/keys/@ yeastydotterel85_key.atKeys -a @ yeastydotterel85 -t @ charlie24
Connecting ... Connected
@ charlie24: hello yeasty
@ yeastydotterel85: hi charlie
@ charlie24: how are you?
@ yeastydotterel85: i'm fine.. what about you?
@ charlie24: doing great
@ charlie24: 123
@ charlie24: 18793
@ charlie24: hellow
@ charlie24: are you fine
@ yeastydotterel85: yayy yes
@ yeastydotterel85: cool
@ yeastydotterel85: hello
@ yeastydotterel85: 123
@ yeastydotterel85: 78172817
@ yeastydotterel85: hello world
@ yeastydotterel85:
@ yeastydotterel85: yes yes

atsign-2
dart bin/at_talk.dart -k /home/shaikirfan/.atsign/keys/@ charlie24_key.atKeys -a @ charlie24 -t @ yeastydotterel85
Connecting ... Connected
@ charlie24: hello yeasty
@ yeastydotterel85: hi charlie
@ charlie24: how are you?
@ yeastydotterel85: i'm fine.. what about you?
@ charlie24: doing great
@ charlie24: 123
@ charlie24: 18793
@ charlie24: hellow
@ charlie24: are you fine
@ yeastydotterel85: yayy yes
@ yeastydotterel85: cool

@murali-shris
Copy link
Member

@gkc at_auth package requires at_chops for pkam signing.
monitor.dart has reading private key from preference as a fallback option.We no longer set privatekey in preference and if useAtChops=false, monitor is failing.

Fix for this issue has to be in at_talk.dart..is this fine?

@gkc
Copy link
Contributor

gkc commented Oct 14, 2023

@murali-shris Shouldn't we instead make useAtChops true by default in at_client? useAtChops was only ever intended as a temporary thing so we could gracefully and safely migrate from the pre-atChops approach

@murali-shris
Copy link
Member

@murali-shris Shouldn't we instead make useAtChops true by default in at_client? useAtChops was only ever intended as a temporary thing so we could gracefully and safely migrate from the pre-atChops approach

yes Gary. We can. We should test there are no legacy code in packages that sets private key in preferences and not setting atChops.

@gkc
Copy link
Contributor

gkc commented Oct 16, 2023

@murali-shris OK please create a P1 ticket for this work asap

@murali-shris
Copy link
Member

@murali-shris OK please create a P1 ticket for this work asap

atsign-foundation/at_client_sdk#1141
I have started working on this task

@murali-shris
Copy link
Member

murali-shris commented Oct 30, 2023

issue fixed and at_client 3.0.66 published

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants