feat: introduce cramAuthenticate and close into atLookup interface #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murali-shris
requested changes
Oct 20, 2023
| /// Optionally pass enrollmentId if the client is enrolled using APKAM | ||
| Future<bool> pkamAuthenticate({String? enrollmentId}); | ||
|
|
||
| /// Generates digest using from verb response and [secret] and performs a | ||
| /// CRAM authentication to secondary server | ||
| Future<bool> cramAuthenticate(var secret); |
There was a problem hiding this comment.
can you rename param from var secret to String secret
There was a problem hiding this comment.
change has been made as part of 6deb45f
murali-shris
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #421
- What I did
- Description for the changelog
feat: introduce cramAuthenticate and close into atLookup interface