Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removed private key reference and from at_lookup_impl #451

Merged
merged 5 commits into from
Dec 5, 2023
Merged

fix: removed private key reference and from at_lookup_impl #451

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
aadac7e
removed private key reference
purnimavenkatasubbu Nov 15, 2023
fd18993
updated version and changelog
purnimavenkatasubbu Dec 4, 2023
cae01c3
Merge branch 'trunk' of https://github.com/atsign-foundation/at_libra…
purnimavenkatasubbu Dec 4, 2023
8b5fab5
review comments
purnimavenkatasubbu Dec 5, 2023
d8aecd0
fixed merge conflict
purnimavenkatasubbu Dec 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/at_lookup/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
## 3.0.42
- fix: removed private key reference from at_lookup_impl
## 3.0.41
- feat: introduce methods cramAuthenticate and close into the AtLookup interface
- deprecate: authenticate_cram() from AtLookupImpl. [cramAuthenticate should be used instead]
Expand Down
8 changes: 2 additions & 6 deletions packages/at_lookup/lib/src/at_lookup_impl.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ class AtLookupImpl implements AtLookUp {

late int _rootPort;

String? privateKey;
purnimavenkatasubbu marked this conversation as resolved.
Show resolved Hide resolved

String? cramSecret;

Expand All @@ -55,7 +54,7 @@ class AtLookupImpl implements AtLookUp {
AtChops? _atChops;

AtLookupImpl(String atSign, String rootDomain, int rootPort,
{this.privateKey,
purnimavenkatasubbu marked this conversation as resolved.
Show resolved Hide resolved
{
this.cramSecret,
SecondaryAddressFinder? secondaryAddressFinder,
SecureSocketConfig? secureSocketConfig,
Expand Down Expand Up @@ -573,14 +572,11 @@ class AtLookupImpl implements AtLookUp {
if (_atChops != null) {
logger.finer('calling pkam using atchops');
await pkamAuthenticate(enrollmentId: enrollmentId);
} else if (privateKey != null) {
logger.finer('calling pkam without atchops');
await authenticate(privateKey);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The above lines of code should not have been removed @sitaram-kalluri

} else if (cramSecret != null) {
await cramAuthenticate(cramSecret!);
} else {
throw UnAuthenticatedException(
'Unable to perform atLookup auth. Private key/cram secret is not set');
'Unable to perform atLookup auth. atChops object is not set');
}
}
try {
Expand Down
2 changes: 1 addition & 1 deletion packages/at_lookup/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: at_lookup
description: A Dart library that contains the core commands that can be used with a secondary server (scan, update, lookup, llookup, plookup, etc.)
version: 3.0.38
version: 3.0.42
repository: https://github.com/atsign-foundation/at_libraries
homepage: https://atsign.com
documentation: https://docs.atsign.com/
Expand Down